marcus/scour
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Don't escape quotes ('/") in text nodes and attributes.

Browse source 
- In text nodes quotes are fine
- In attributes quotes are fine if used reciprocally.

Escaping in the latter case often causes issues, e.g. with quoted font names (#21) or inline CSS styles (#56), while it probably does not gain anything (if quotes are wrongly used in attribute names the XML is most likely invalid to start with)
This commit is contained in:
Eduard Braun 2016-08-16 00:07:29 +02:00
parent fe2884c3e8
commit 738b7d7c5d
2 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
scour/scour.py
View file

@ -2752,7 +2752,10 @@ def remapNamespacePrefix(node, oldprefix, newprefix):
def makeWellFormed(str):
xml_ents = { '<':'&lt;', '>':'&gt;', '&':'&amp;', "'":'&apos;', '"':'&quot;'}
# Don't escape quotation marks for now as they are fine in text nodes
# as well as in attributes if used reciprocally
# xml_ents = { '<':'&lt;', '>':'&gt;', '&':'&amp;', "'":'&apos;', '"':'&quot;'}
xml_ents = { '<':'&lt;', '>':'&gt;', '&':'&amp;'}
# starr = []
# for c in str: