marcus/scour
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix Bug 361817: wrong shebang line. Added tests for removing duplicate gradient stops and useless nested groups (neither of which pass yet)

Browse source
This commit is contained in:
JSCHILL1 2009-04-15 11:44:12 -05:00
parent 359c42166f
commit 747a282f5f
3 changed files with 24 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

10
scour.py
View file

@ -1,6 +1,7 @@
#!/usr/local/bin/python #!/usr/bin/env python
# Scour # Scour
# Version 0.07 # Version 0.08
# #
# Copyright 2009 Jeff Schiller # Copyright 2009 Jeff Schiller
# #
@ -47,9 +48,8 @@
# * Collapse all group based transformations # * Collapse all group based transformations
# Next Up: # Next Up:
# - Remove duplicate gradient stops
# - Remove unnecessary nested <g> elements # - Remove unnecessary nested <g> elements
# - Pretty up whitespace nodes on output # - Remove duplicate gradient stops
# - Convert all colors to #RRGGBB format # - Convert all colors to #RRGGBB format
# - rework command-line argument processing so that options are configurable # - rework command-line argument processing so that options are configurable
# - remove unreferenced patterns? https://bugs.edge.launchpad.net/ubuntu/+source/human-icon-theme/+bug/361667/ # - remove unreferenced patterns? https://bugs.edge.launchpad.net/ubuntu/+source/human-icon-theme/+bug/361667/
@ -69,7 +69,7 @@ import os.path
import urllib import urllib
APP = 'scour' APP = 'scour'
VER = '0.07' VER = '0.08'
COPYRIGHT = 'Copyright Jeff Schiller, 2009' COPYRIGHT = 'Copyright Jeff Schiller, 2009'
NS = { 'SVG': 'http://www.w3.org/2000/svg', NS = { 'SVG': 'http://www.w3.org/2000/svg',

15
testscour.py
View file

@ -138,11 +138,18 @@ class RemoveUnreferencedRadialGradient(unittest.TestCase):
self.assertEquals(len(doc.getElementsByTagNameNS('http://www.w3.org/2000/svg', 'radialradient')), 0, self.assertEquals(len(doc.getElementsByTagNameNS('http://www.w3.org/2000/svg', 'radialradient')), 0,
'Unreferenced radialGradient not removed' ) 'Unreferenced radialGradient not removed' )
# These tests will fail at present # These tests will fail at present
#class RemoveDuplicateGradientStops(unittest.TestCase): class RemoveUselessNestedGroups(unittest.TestCase):
# def runTest(self): def runTest(self):
# doc = scour.scourXmlFile('unittests/duplicate-gradient-stops.svg') doc = scour.scourXmlFile('unittests/nested-useless-groups.svg')
self.assertEquals(len(doc.getElementsByTagNameNS('http://wwww.w3.org/2000/svg', 'g')), 1,
'Useless nested groups not removed' )
class RemoveDuplicateGradientStops(unittest.TestCase):
def runTest(self):
doc = scour.scourXmlFile('unittests/duplicate-gradient-stops.svg')
self.assertEquals(len(doc.getElementsByTagNameNS('http://www.w3.org/2000/svg', 'stop')), 3,
'Duplicate gradient stops not removed' )
if __name__ == '__main__': if __name__ == '__main__':
unittest.main() unittest.main()

8
unittests/nested-useless-groups.svg Normal file
View file

@ -0,0 +1,8 @@
<svg xmlns="http://www.w3.org/2000/svg">
<g>
<g transform="translate(50,50)">
<rect width="300" height="200" fill="green" />
<circle cx="200" cy="100" r="50" fill="yellow" />
</g>
</g>
</svg>
Side by side

After

Width:  |  Height:  |  Size: 197 B